-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wgsl-in, wgsl-out, glsl-in] WebGPU compliant dual source blending feature #7146
Open
Wumpf
wants to merge
10
commits into
gfx-rs:trunk
Choose a base branch
from
Wumpf:webgpu-dual-source-blending
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d101739
to
ccbb722
Compare
b14e3e1
to
a15afa0
Compare
a15afa0
to
615acda
Compare
@Wumpf: Rebased and fixed up CI blockers. CI was unhappy because:
|
Had the same thought |
Yeah, I think we should remove |
Filed #7252 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: naga back-end
Outputs of naga shader conversion
area: naga front-end
area: naga processing
Passes over IR in the middle
area: validation
Issues related to validation, diagnostics, and error handling
lang: GLSL
OpenGL Shading Language
naga
Shader Translator
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Description
Makes the dual source implementation in wgpu WebGPU spec compliant.
This means changing the wgsl syntax & associated validation to match what's described here and here and here.
Furthermore, makes the dual source blending extension available when targeting WebGPU.
In order to reliably test wgsl output I incorrectly assumed that the way to go would be to add a glsl input to the snapshot tests (mostly to check for the
enable
directive being written out correctly), didn't realize that there's wgsl->wgsl snapshot testing as well, so I ended up implementing glslindex
parsing as collateral😄Testing
Added a slew of naga tests. Did manual testing in a pet project against native & WebGPU
Draft TODO
[help wanted] [partially orthogonal]: While trying this out on my pet project I couldn't get it to fly in WebGPU because I was using naga_oil (with a hack, see also Support wgsl diagnostic directives. bevyengine/naga_oil#113 (comment)) where I have to rely onModule
->write_wgsl
which right now ignores all directives 😱 . Fixing that isn't entirely straight forward sinceModule
is language agnostic so I have to detect the need for thoseChecklist
cargo fmt
.taplo format
.cargo clippy
. If applicable, add:--target wasm32-unknown-unknown
cargo xtask test
to run tests.CHANGELOG.md
. See simple instructions inside file.