Skip to content

Conversation

@cwfitzgerald
Copy link
Member

Connections

Closes #6854

Description

This properly unifies validation for multi-draw indirect. It also properly exposes the fact that all backends emulate MDI if it is not available.

Testing

MDI doesn't have any real testing, but that's probably out of scope for this issue.

Checklist

  • Run cargo fmt.
  • Run taplo format.
  • Run cargo clippy. If applicable, add:
    • --target wasm32-unknown-unknown
    • --target wasm32-unknown-emscripten
  • Run cargo xtask test to run tests.
  • Add change to CHANGELOG.md. See simple instructions inside file.

@cwfitzgerald cwfitzgerald requested a review from a team as a code owner January 7, 2025 01:46
Copy link
Member

@teoxoy teoxoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teoxoy teoxoy merged commit fabcba8 into gfx-rs:trunk Jan 7, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

multi_draw_indirect dispatches one draw call even when count is set to 0

2 participants