Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type/Expression Tandem #6806

Closed
wants to merge 42 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
8db0b19
type/expression tandem
kentslaney Dec 22, 2024
364b74e
broken tandem test
kentslaney Dec 30, 2024
3b56706
`fmt`
kentslaney Dec 30, 2024
cbd991e
tandem explanation
kentslaney Dec 30, 2024
e41f5f3
explain tmp intermediaries
kentslaney Dec 30, 2024
63b9290
move all tracing into tandem fn
kentslaney Dec 31, 2024
4009251
fn guide
kentslaney Dec 31, 2024
d412b3e
move types_used_insert into ExpressionTracer
kentslaney Dec 31, 2024
cc2cbfe
mark traced types as used
kentslaney Dec 31, 2024
8ad71e3
Merge branch 'trunk' into compact-leak
kentslaney Dec 31, 2024
18a54e4
good-enough check that doesn't modify crate::Module
kentslaney Dec 31, 2024
5ead8a3
remove debugging statements
kentslaney Dec 31, 2024
c9c38b2
validate order as defined in #6788 (mostly via #6800)
kentslaney Jan 3, 2025
babbb86
insert order check
kentslaney Jan 3, 2025
c5726e5
`fmt` & `clippy`
kentslaney Jan 4, 2025
a3588df
ignore well-order requirement for emscripten since it doesn't compact
kentslaney Jan 4, 2025
7f5a858
redeclare full check for compact
kentslaney Jan 4, 2025
9c7159b
clippy via github actions
kentslaney Jan 4, 2025
b9a5e7a
changelog
kentslaney Jan 4, 2025
61bc9e7
Merge remote-tracking branch 'upstream/trunk' into compact-leak
kentslaney Jan 4, 2025
5b32766
better equality check
kentslaney Jan 6, 2025
fdc2cfc
better variable names
kentslaney Jan 6, 2025
c081c99
remove git remnants from changelog
kentslaney Jan 6, 2025
e05b7be
Merge branch 'trunk' into compact-leak
kentslaney Jan 8, 2025
3e32858
avoid deriving PartialEq for module
kentslaney Jan 14, 2025
aa670cb
remove already-guaranteed check but not test
kentslaney Jan 14, 2025
c767840
remove unused dependencies
kentslaney Jan 14, 2025
b53d6ca
remove call to well_ordered_deps
kentslaney Jan 14, 2025
c20f545
correct the block comment explaining type_expression_tandem
kentslaney Jan 15, 2025
01e8e1c
better variable names
kentslaney Jan 15, 2025
a527f57
stop if type is already marked used
kentslaney Jan 15, 2025
f48fb3d
explanation for the optional types
kentslaney Jan 15, 2025
3fcdae7
80 character limit for comments (?)
kentslaney Jan 15, 2025
88ed425
github's monospace breaks box-drawing characters
kentslaney Jan 15, 2025
daa9dcc
Merge remote-tracking branch 'upstream/trunk' into compact-leak
kentslaney Jan 16, 2025
ba5335a
clippy
kentslaney Jan 16, 2025
9d3f40d
modify test to fail on trunk
kentslaney Jan 16, 2025
80ad878
`fmt`
kentslaney Jan 16, 2025
b8d5d0a
`clippy`
kentslaney Jan 16, 2025
2a2c42b
valid test that fails on trunk
kentslaney Jan 16, 2025
553d39b
better variable names
kentslaney Jan 16, 2025
836a97d
Merge branch 'trunk' into compact-leak
kentslaney Jan 16, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
valid test that fails on trunk
  • Loading branch information
kentslaney committed Jan 16, 2025
commit 2a2c42b3e8844ae042fe460c4f4cd6a17a362ad6
9 changes: 7 additions & 2 deletions naga/src/compact/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -475,7 +475,12 @@ fn type_expression_interdependence() {
let untouched = module.clone();
compact(&mut module);
assert!(cmp_modules(&module, &untouched));
expression_needs_type(&mut module, ty_trace);
compact(&mut module);
let unused_expr = module.global_expressions.append(
crate::Expression::Literal(crate::Literal::U32(1)),
crate::Span::default(),
);
type_needs_expression(&mut module, unused_expr);
assert!(!cmp_modules(&module, &untouched));
compact(&mut module);
assert!(cmp_modules(&module, &untouched));
}
Loading