Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move more code into methods on wgpu-core objects #6391

Merged
merged 15 commits into from
Oct 14, 2024
Merged

Move more code into methods on wgpu-core objects #6391

merged 15 commits into from
Oct 14, 2024

Conversation

teoxoy
Copy link
Member

@teoxoy teoxoy commented Oct 10, 2024

Another step towards #5121.

@teoxoy teoxoy requested a review from a team as a code owner October 10, 2024 15:28
@teoxoy teoxoy force-pushed the move-methods branch 3 times, most recently from 85cc083 to 2b52cf9 Compare October 10, 2024 15:50
Wumpf
Wumpf approved these changes Oct 13, 2024
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! things getting more and more clearer, like a fog slowly lifting :)
extra cool that you got to replace a unwrap surface case with more graceful error handling in the process!

wgpu-core/src/command/transfer.rs Outdated Show resolved Hide resolved
@teoxoy
add new Instance::as_hal fn
9bd617c
@teoxoy
move request_adapter on the Instance
c3cd711
@teoxoy
add Adapter::backend()
4a3cb18
@teoxoy
add adapter getters
0bb8c16
@teoxoy
make remaining Adapter methods public
7cf9655
@teoxoy
make Fallible<T> public
f9195ed
@teoxoy
move queue methods on the Queue type
ed7bd0d
@teoxoy
move enumerate_adapters on the Instance
8bb0d8a
@teoxoy
move surface creation methods on the Instance
bd5dba6
@teoxoy
remove parent_id field of TextureInner::Surface
ac9ebd7 
The `parent_id` will always match `surface_id` because we got the texture from the `acquired_texture` field.
@teoxoy
Improve the ownership story of textures returned by `get_current_text…
c00f5e8 
…ure`

`present` and `discard` will no longer automatically remove the texture from the registry.
@teoxoy
add SurfaceError::TextureDestroyed
bca3a41
@teoxoy
move surface methods on the Surface
59ea3ef
@teoxoy
impl Drop for Surface
1728c16
@teoxoy
remove Hub.clear()
430b406
@teoxoy teoxoy enabled auto-merge (rebase) October 14, 2024 11:15
@teoxoy teoxoy merged commit c0e3972 into gfx-rs:trunk Oct 14, 2024
27 checks passed
@teoxoy teoxoy deleted the move-methods branch October 14, 2024 11:26
@teoxoy teoxoy self-assigned this Oct 14, 2024
@ErichDonGubler ErichDonGubler mentioned this pull request Oct 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

@crowlKats crowlKats Awaiting requested review from crowlKats crowlKats is a code owner

Assignees

@teoxoy teoxoy

Labels
None yet
Projects
WebGPU for Firefox
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teoxoy @Wumpf