Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[naga spv-out] Expand LocalType to permit pointers to matrices. #6387

Merged
merged 2 commits into from
Oct 10, 2024
Merged

[naga spv-out] Expand LocalType to permit pointers to matrices. #6387

merged 2 commits into from
Oct 10, 2024

Commits on Oct 9, 2024

  1. [naga spv-out] Rename make_local to LocalType::from_inner. 

    Change the free function `back::spv::make_local` into an associated
function `LocalType::from_inner`.
    @jimblandy
    jimblandy committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    9afaf53 View commit details
    Browse the repository at this point in the history

  2. [naga spv-out] Expand LocalType to permit pointers to matrices. 

    In `back::spv`:

- Factor out the numeric variants of `LocalType` into a
  new enum, `NumericType`.

- Split the `Value` variant into `Numeric` and `LocalPointer`
  variants, and let `LocalPointer` point to any numeric type,
  including matrices.

In subsequent commits, we'll need to spill matrices out into temporary
local variables. This means we'll need to generate SPIR-V
pointer-to-matrix types, so `LocalType` needs to be able to represent
that.
    @jimblandy
    jimblandy committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    3c926cf View commit details
    Browse the repository at this point in the history