Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wgpu-hal] Upgrade to glutin 0.31.3, narrow libloading to 0.8 #5649

Closed

Conversation

ErichDonGubler
Copy link
Member

@ErichDonGubler ErichDonGubler commented May 2, 2024

This eliminates a ton of duplicate dependencies. Woot! Firefox is finally ready for incremental update of libloading, so we can make this change without any hassle. 😀

Depends on #5504, to have no dependency on libloading 0.7.

@ErichDonGubler ErichDonGubler self-assigned this May 2, 2024
@cwfitzgerald

This comment was marked as duplicate.

@ErichDonGubler ErichDonGubler marked this pull request as ready for review May 14, 2024 14:01
@ErichDonGubler ErichDonGubler requested a review from a team as a code owner May 14, 2024 14:02
@ErichDonGubler
Copy link
Member Author

@cwfitzgerald: It seems we need to pick an optional backend feature for glutin now (as indicated by CI)? I don't know immediately what the right answer is, tho. 😖

@teoxoy
Copy link
Member

teoxoy commented May 15, 2024

They get automatically enabled, the issue is that iOS support was removed in v0.30.

So, I think we should just skip building the example on iOS.

@teoxoy
Copy link
Member

teoxoy commented May 15, 2024

What about this? Should we remove it or bump it as well?

wgpu/Cargo.toml

Line 154 in 77a83fb

glutin = "0.29.1"

Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For tracking

@MarijnS95
Copy link
Contributor

@ErichDonGubler what's needed to finish this, port the raw-gles.rs example because glutin completely removed winit from its core and is now a proper wrapper around GL context creation (kind of doing the exact same thing as your wgl.rs, egl.rs etc)?

I'd love to push this through to further reduce dependencies on winapi :)

@ErichDonGubler
Copy link
Member Author

@MarijnS95: Honestly, this just needs somebody to drive it to completion. I'm happy to cede this PR to you, if you have the bandwidth.

@MarijnS95
Copy link
Contributor

MarijnS95 commented Aug 12, 2024

@ErichDonGubler bandwidth is tight, but I've written and worked on my fair share of glutin codebases over the years so I might be able to pick this up and get it over with in a short amount of time.

@Wumpf
Copy link
Member

Wumpf commented Aug 18, 2024

#5709 highlights that glutin drags in winit right now, making it a holdout for winit 0.27
(dev dependency only still though)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants