Remove G parameter in Global<G> and generic IdentityHandlerFactory #5159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
udoprog
changed the title
nical
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Last step in #5105
CC @nical
Description
Removes the generic
Gparameter toGlobal<G>which is the last blocker towards starting work that needs the methods provided by it to be somewhat object safe.A consequence of this is that in order to provide the same level of behavior in a non-generic way, we have to pass in
Option<ConcreteId>for methods which supports supplying custom identifiers during construction. Long term, these methods are expected to be refactored in concert with #5121.Testing
Ran existing test suites. This is also a breaking change, since
()can no longer be used as an identifier and constructingGlobaldoesn't require the passing in of a factory.Checklist
cargo fmt.cargo clippy. If applicable.cargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file. (TODO)