Split MSRV in Two Parts#4204
Merged
Merged
Conversation
cwfitzgerald
commented
Oct 4, 2023
cwfitzgerald
left a comment
cwfitzgerald
left a comment
Member
Author
There was a problem hiding this comment.
I'm sending this through without review as it should be strictly additive and requires some administrative changes after it lands. If there are any issues, we can touch it up later.
Merged
DJMcNab
added a commit
to DJMcNab/wgpu
that referenced
this pull request
May 22, 2024
A version of rustup which doesn't understand toml-formatted `rust-toolchain` files won't be looking in `rust-toolchain.toml` The file was renamed to `rust-toolchain.toml` in gfx-rs#4204 rust-toolchain.toml support was added in rustup 1.23, which was released on 2020-11-27 [1], 3 and a half years ago. [1]: https://blog.rust-lang.org/2020/11/27/Rustup-1.23.0.html
6 tasks
ErichDonGubler
pushed a commit
that referenced
this pull request
May 22, 2024
A version of rustup which doesn't understand toml-formatted `rust-toolchain` files won't be looking in `rust-toolchain.toml` The file was renamed to `rust-toolchain.toml` in #4204 rust-toolchain.toml support was added in rustup 1.23, which was released on 2020-11-27 [1], 3 and a half years ago. [1]: https://blog.rust-lang.org/2020/11/27/Rustup-1.23.0.html
jimblandy
pushed a commit
to jimblandy/wgpu
that referenced
this pull request
May 23, 2024
A version of rustup which doesn't understand toml-formatted `rust-toolchain` files won't be looking in `rust-toolchain.toml` The file was renamed to `rust-toolchain.toml` in gfx-rs#4204 rust-toolchain.toml support was added in rustup 1.23, which was released on 2020-11-27 [1], 3 and a half years ago. [1]: https://blog.rust-lang.org/2020/11/27/Rustup-1.23.0.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR splits our MSRV into two sections:
We need this as both #4143 and #3873 require 1.70 for various non-core parts due to incidental dependencies.