List Dx12 adapters before vulkan ones #4156
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lets see if this affects wgpu's own CI. |
|
Related: Firefox's bug 1836816 |
ErichDonGubler
approved these changes
Sep 20, 2023
|
I thought #2719 is a prerequisite for this.
I don't think it will since wgpu's Windows CI has no Vulkan drivers installed (it always uses WARP). |
|
Closing as #2719 is a hard prereq |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy.Description
I'm not sure whether it's possible to see vulkan adapters on Mac (maybe with moltenvk). In any case, on Windows and Mac it makes more sense to present Dx12 and Metal first, so that programs that pick the first adapter (for example the CTS), get the most sensible default.
Dx11 being more of a fallback option should still be after vulkan on windows.