Skip to content

More as_hal() methods #3376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 100 commits into from
Closed

More as_hal() methods #3376

wants to merge 100 commits into from

Conversation

JMS55
Copy link
Collaborator

@JMS55 JMS55 commented Jan 13, 2023

Checklist

  • Run cargo clippy.
  • Run RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown if applicable.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Description

@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2023

Codecov Report

Merging #3376 (d7dcc9b) into master (4400ff8) will increase coverage by 0.33%.
The diff coverage is 1.13%.

@@            Coverage Diff             @@
##           master    #3376      +/-   ##
==========================================
+ Coverage   64.64%   64.97%   +0.33%     
==========================================
  Files          86       86              
  Lines       42722    42890     +168     
==========================================
+ Hits        27616    27867     +251     
+ Misses      15106    15023      -83     
Impacted Files Coverage Δ
wgpu-core/src/resource.rs 19.48% <0.00%> (-5.66%) ⬇️
wgpu-hal/src/dx11/adapter.rs 0.00% <0.00%> (ø)
wgpu-hal/src/dx11/mod.rs 0.00% <ø> (ø)
wgpu-hal/src/dx12/adapter.rs 80.34% <0.00%> (-1.05%) ⬇️
wgpu-hal/src/dx12/mod.rs 27.27% <ø> (ø)
wgpu-hal/src/empty.rs 0.00% <0.00%> (ø)
wgpu-hal/src/gles/adapter.rs 83.03% <0.00%> (-0.70%) ⬇️
wgpu-hal/src/gles/mod.rs 61.53% <ø> (ø)
wgpu-hal/src/lib.rs 26.92% <ø> (ø)
wgpu-hal/src/vulkan/adapter.rs 78.24% <0.00%> (-0.34%) ⬇️
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@JMS55 JMS55 marked this pull request as ready for review January 13, 2023 16:37
@JMS55 JMS55 changed the title More hal exposures More as_hal() methods Jan 13, 2023
@JMS55 JMS55 marked this pull request as draft January 17, 2023 20:04
@JMS55 JMS55 marked this pull request as ready for review February 27, 2023 22:47
@JMS55 JMS55 requested a review from crowlKats as a code owner July 23, 2023 18:57
@JMS55
Copy link
Collaborator Author

JMS55 commented Jul 23, 2023

I've accidentally majorly screwed up this PR while trying to rebase :/. Going to delete this and try again...

@JMS55 JMS55 closed this Jul 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow hooking into command buffers on a backend-specific basis
4 participants