-
Notifications
You must be signed in to change notification settings - Fork 1.1k
More as_hal() methods #3376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
More as_hal() methods #3376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y implementation, run cargo clippy, fix wgpu/wgpu build
…me links to implementation resources.
…u into hal-acceleration-structures
Codecov Report
@@ Coverage Diff @@
## master #3376 +/- ##
==========================================
+ Coverage 64.64% 64.97% +0.33%
==========================================
Files 86 86
Lines 42722 42890 +168
==========================================
+ Hits 27616 27867 +251
+ Misses 15106 15023 -83
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
…leration-structures
…ing + hub clear fix (added tlas instance buffer)
I've accidentally majorly screwed up this PR while trying to rebase :/. Going to delete this and try again... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy
.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown
if applicable.Description
Texture::as_hal()
callback to return a value, matching other as_hal callbacksTextureView::as_hal()
CommandEncoder::as_hal_mut()
(closes Allow hooking into command buffers on a backend-specific basis #3517)Adapter::texture_format_as_hal()