Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #3151 Without Breaking Changes #3165

Merged
merged 1 commit into from
Nov 2, 2022

Conversation

cwfitzgerald
Copy link
Member

Checklist

  • Run cargo clippy.
  • Run RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown if applicable.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Connections

Fixes #3112

Description

Makes wgpu::TextureFormat::Depth24PlusStencil8 available on all backends by making the feature unconditionally available and the feature unneeded to use the format.

Testing

Local tests were run.

@cwfitzgerald
Copy link
Member Author

The test failed, but the test failed via segfault on lavapipe, so I'm going to ignore that failure and push on.

@cwfitzgerald cwfitzgerald merged commit f31ff6a into gfx-rs:v0.14 Nov 2, 2022
@cwfitzgerald cwfitzgerald deleted the backport-3151 branch November 2, 2022 21:31
relrelb added a commit to relrelb/ruffle that referenced this pull request Nov 3, 2022
This reverts ruffle-rs#8297. Instead, pin `wgpu-hal` and `wgpu-types` to
include gfx-rs/wgpu#3165, which fixes
gfx-rs/wgpu#3112.
relrelb added a commit to ruffle-rs/ruffle that referenced this pull request Nov 3, 2022
This reverts #8297. Instead, pin `wgpu-hal` and `wgpu-types` to
include gfx-rs/wgpu#3165, which fixes
gfx-rs/wgpu#3112.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants