Set the image stride to zero when updating a single layer on metal. - #3063
Merged
Conversation
The test is more valuable when run with the validation layer enabled, but even without it, it's better than nothing.
cwfitzgerald
approved these changes
Oct 5, 2022
cwfitzgerald
left a comment
Member
There was a problem hiding this comment.
You and your amazing tests 😍
Got into the latest :)
cwfitzgerald
enabled auto-merge (squash)
October 5, 2022 20:52
Member
|
Seems like this code is broken on windows too 😆 |
Member
|
Should we also do the same for
The docs of The stackoverflow post in the issue #3062 (comment) was also referring to I assume this hasn't been an issue since the test copies back the full texture and not a subregion. |
3 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Probably just a tad late to make the cut to the next version, but perhaps it could squeeze in a dot release?
Checklist
cargo clippy.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknownif applicable.Connections
Fixes #3062
Description
When updating a single layer of a texture on metal, set the stride to zero to avoid angering the validatio layer.