allow creation of wgpu_hal textures for gles backend #3046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i509VCB
force-pushed
the
gles-texture-from-raw
branch
3 times, most recently
from
82a7202
to
9abc9eb
Compare
i509VCB
force-pushed
the
gles-texture-from-raw
branch
4 times, most recently
from
f1c6dc3
to
28f04cf
Compare
|
It'd be great to be able to roll the functionality in #2609 into this! I think it'd require something like this: pub unsafe fn texture_from_raw(
&self,
raw_texture: RawTexture,
...
)enum RawTexture {
Name(&str),
WebGl(web_sys::WebGlFramebuffer)
} |
cwfitzgerald
requested changes
Oct 12, 2022
This should be enough to allow RGB external textures to work on Linux. For Android, we still need to implement logic to generate shaders with samplerOESExternal and select the correct shader depending on the type of texture being created.
i509VCB
force-pushed
the
gles-texture-from-raw
branch
from
28f04cf
to
0360e60
Compare
cwfitzgerald
approved these changes
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknownif applicable.Connections
Relating to #2320, this should expose enough to allow external textures to work on Linux. I will write a further explanation on the linked issue about Android and what is covered so far by that issue.
Description
Add functions to create gles textures from external objects. Specifically, from a GL texture and GL renderbuffer.
Note: This pull request will need a new glow release at some point in the future.