pass around RawDisplayHandle and RawWindowHandle in implementation #3022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is to help with an attempt to allow the Context type in wgpu to be swappable at runtime. In order to do that, the functions provided by Context and it's associated types need to be object safe. Instead of passing a impl trait that combines both HasRawWindowHandle and HasRawDisplayHandle, we seperate the types into their RawDisplayHandle and RawWindowHandle parts internally to reduce some of the hal implementation code mess.
jimblandy
approved these changes
Sep 15, 2022
jimblandy
added a commit
to jimblandy/wgpu
that referenced
this pull request
Oct 13, 2022
As of gfx-rs#3022, this is no longer needed.
jimblandy
added a commit
to jimblandy/wgpu
that referenced
this pull request
Oct 13, 2022
As of gfx-rs#3022, the local `init` function no longer needs a dummy argument.
jimblandy
added a commit
to jimblandy/wgpu
that referenced
this pull request
Oct 13, 2022
As of gfx-rs#3022, the local `init` function no longer needs a dummy argument.
jimblandy
added a commit
to jimblandy/wgpu
that referenced
this pull request
Oct 13, 2022
As of gfx-rs#3022, the local `init` function no longer needs a dummy argument.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknownif applicable.Connections
There has been discussion on Matrix to allow swapping the "Context" type inside wgpu at runtime.
Description
This change is to help with an attempt to allow the Context type in wgpu to be swappable at runtime in the future.
In order to do that, the functions provided by a dynamic blanket implemented Context and it's associated types need to be object safe. For surface creation, instead of passing a impl trait that combines both HasRawWindowHandle and HasRawDisplayHandle, we separate the types into their RawDisplayHandle and RawWindowHandle parts internally.