Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing validation in copy_texture_to-Buffer. #2958

Merged
merged 2 commits into from
Aug 13, 2022

Conversation

nical
Copy link
Contributor

@nical nical commented Aug 12, 2022

Checklist

  • Run cargo clippy.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Connections

Spec: https://gpuweb.github.io/gpuweb/#dom-gpucommandencoder-copytexturetobuffer
Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1774456

Description

Another missing validation found by fuzzers.

Per WebGPU spec:

  • The source sample count must be 1
  • the requested mip level must be < mip level count.

Per WebGPU spec:
 - The source sample count must be 1
 - the requested mip level must be < mip level count.
@cwfitzgerald cwfitzgerald merged commit 96a85b3 into gfx-rs:master Aug 13, 2022
@nical nical deleted the copy-tex-to-buf branch August 14, 2022 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants