Fix opening of renderdoc lib #2930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renderdoc needs to not be opened by us, but instead open the existing copy. Unfortunately this requires OS specific flags for opening, plus `libloading` doesn't have full API coverage currently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknownif applicable.Connections
Same issue in ebkalderon/renderdoc-rs#128
Fixes #2793
Description
Renderdoc needs to not be opened by us, but instead open the existing copy.
This currently requires OS specific flags for opening and
libloadingdoesn't have full API coverage.Testing
The examples didn't work before, now they work fine.
Although I was just able to test Linux only, so anyone who wants to make a quick test with RenderDoc on Windows and Mac would be great.