Validate the number of color attachments in create_render_pipeline #2913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Returns an error instead of panicking when populating an ArrayVec later in the same function.
cwfitzgerald
approved these changes
Jul 26, 2022
| return Err( | ||
| pipeline::CreateRenderPipelineError::TooManyColorAttachments { | ||
| given: num_attachments as u32, | ||
| limit: hal::MAX_COLOR_ATTACHMENTS as u32, |
There was a problem hiding this comment.
Long term we should add this limit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy.Connections
Found by a fuzzer in https://bugzilla.mozilla.org/show_bug.cgi?id=1780791
Description
create_render_pipelinepanics if the number of color attachments is greater thanhal::MAX_COLOR_ATTACHMENTS.This PR checks and returns an error. This validation is also part of the WebGPU spec (although the limit is advertized via a member of
GPUSupportedLimitsinstead of a constant).Testing
None.