Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add create_texture_error #2800

Merged
merged 1 commit into from
Jun 22, 2022
Merged

Conversation

nical
Copy link
Contributor

@nical nical commented Jun 22, 2022

Description

Firefox needs it to implement WebGPU's error model (see create_buffer_error). The WebGPU specification allows texture descriptors that are not allowed by wgpu's TextureDescriptor type such as the usage bitfield. Firefox takes care of validating these special cases, however the invalid textures have to be registered which is done via this method. See also create_buffer_error.

Testing

None.

Firefox needs it to implement WebGPU's error model (see create_buffer_error).
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@cwfitzgerald cwfitzgerald enabled auto-merge (squash) June 22, 2022 12:55
@cwfitzgerald cwfitzgerald merged commit a9f1b4f into gfx-rs:master Jun 22, 2022
atadier pushed a commit to atadier/wgpu that referenced this pull request Jun 23, 2022
Firefox needs it to implement WebGPU's error model (see create_buffer_error).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants