allow creating wgpu::Instance from wgpu_core::Instance #2763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i509VCB
force-pushed
the
instance-from-core
branch
from
3bb1615
to
d77719d
Compare
jimblandy
requested changes
Jun 15, 2022
i509VCB
force-pushed
the
instance-from-core
branch
from
d77719d
to
0b7e0da
Compare
jimblandy
approved these changes
Jun 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When creating custom hal instances, you may want to do so for multiple backends. Since a wgpu_core::Instance may have multiple instance members constructed, that is probably the best spot to deal with multiple custom wgpu_hal backends.
I do this specifically in my wgpu fork to integrate with some Linux specific APIs and want to be able to use EGL and Vulkan adapters.