Expose naga span location helpers #2752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @jimblandy |
nical
force-pushed
the
span-location
branch
4 times, most recently
from
bf118b3
to
b960853
Compare
nical
force-pushed
the
span-location
branch
3 times, most recently
from
17d7122
to
e290f4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This exposes the
locationmethod from naga errors. The idea is to let the user obtain anOption<naga::SourceLocation>out ofCreateShaderModuleErrorwithout matching on the internal error types.This PR also bumps the naga dependency to a more recent revision since the
locationmethods were added recently. Note that the glsl backend recently got bounds check for image loads in gfx-rs/naga#1889, I left the extra parameter disabled in this PR to get the code to build.Testing
None (the location method has a test in naga).