Re-enable GL testing in CI #2508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwfitzgerald
force-pushed
the
fix-gles-test-2
branch
from
ae251f1
to
71624b6
Compare
kvark
approved these changes
Feb 25, 2022
cwfitzgerald
force-pushed
the
fix-gles-test-2
branch
4 times, most recently
from
8b712c2
to
4da77a3
Compare
cwfitzgerald
force-pushed
the
fix-gles-test-2
branch
from
ecb0b11
to
8605899
Compare
|
Re-requesting review on this, I've rebased against merged master. Same deal, commits are free-standing and should be reviewed individually. Most should be pretty uncontroversial, but I added a downlevel flag, and added a validation canary to wgpu-hal, which you should take a look at. |
cwfitzgerald
force-pushed
the
fix-gles-test-2
branch
from
57c7e20
to
b885200
Compare
cwfitzgerald
force-pushed
the
fix-gles-test-2
branch
from
b885200
to
7fe016f
Compare
kvark
approved these changes
Feb 28, 2022
kvark
requested changes
Feb 28, 2022
kvark
approved these changes
Mar 1, 2022
cwfitzgerald
pushed a commit
that referenced
this pull request
Oct 25, 2023
* [valid] disallow NaNs and infinities * document literal float constraints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
This is a follow up to #2504, currently in draft state to get CI to run. Will rebase once it is merged in.
Description
GL testing back on CI!
Testing
It is.