IdentityManager: from_index method is unneeded.
#2424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimblandy
force-pushed
the
remove-min-index
branch
from
fb422af
to
324ae36
Compare
The `min_index` parameter has no useful effect. Because the range 0..n is pushed on the free list, index values less than `min_index` do get allocated. Document `IdentityManager` and `TypedId`.
jimblandy
force-pushed
the
remove-min-index
branch
from
324ae36
to
22c7c0a
Compare
kvark
approved these changes
Jan 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
min_indexparameter has no useful effect. Because the range 0..n is pushedon the free list, index values less than
min_indexdo get allocated.Document
IdentityManagerandTypedId.