hal/gles: fix index buffer state not being reset in reset_state

[rparrett]

Connections

Fixes #2378

Description

See discussion in #2378 for the full background.

This fixes a webgl2 crash that I have been experiencing. The old gfx gl implementation that hal/gles is based on did the same thing and this seemingly was an unintentional omission when porting it.

Testing

Tested webgl examples that are expected to work

• cube
• hello-triangle
• msaa-line
• shadow
• skybox
• water

I observed some unpleasant flickering in cube both with and without these changes.

[kvark]

Very nice!

[kvark]

Thank you! Do you require this patch on crates?

[rparrett]

I do not, but I personally think it's a good idea / would appreciate it.

Some factors I'm thinking about are:

• The way this sort of bubbled up randomly into a pretty unremarkably bevy game,
• Bevy users not really having any options to mitigate this as far as I can tell
• Bevy and wgpu's release schedules
• An upcoming bevy game jam

But I don't fully understand the full chain from bevy code to the crash this fixes or how rare the situation might be.

[rparrett]

If it's an ordeal, at least the issue is a bit more discoverable now and bevy still seems to be compatible with wgpu up to this commit so users can simply patch wgpu.

[kvark]

We will definitely release a patch for this. No need to align any release schedules.
The question is how urgent this patch needs to be.

[rparrett]

Oh, probably not very urgent at all.

[kvark]

published in wgpu-hal-0.12.3

[rparrett]

Thanks!