Add pipeline statistics and timeline queries #1128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![monocodus[bot]](https://avatars.githubusercontent.com/in/28526?s=60&v=4){kind=small}
kvark
reviewed
Jan 5, 2021
|
Alright, this is still blocked on gfx updates and I need to add queries to traces, but the core changes are ready for second pass review. |
|
Traces are added |
cwfitzgerald
force-pushed
the
queries
branch
3 times, most recently
from
f16db06 to
bbdd653
Compare
kvark
reviewed
Jan 10, 2021
wgpu-core/src/command/query.rs
Outdated
| query_type: SimplifiedQueryType, | ||
| query_set_id: id::QuerySetId, | ||
| query_index: u32, | ||
| reset_state: &mut Option<&mut QueryResetMap>, |
There was a problem hiding this comment.
oh wow, first time seeing this pattern!
Why is it not just reset_state: Option<&mut QueryResetMap>?
There was a problem hiding this comment.
Because I need to use the option later on as well. If I pass it by value I can't use it later in the function. I need to get (from the option) a &mut &mut QueryResetMap, which is only possible when the reference to the option is also mut.
|
Finishing up wgpu-rs PR then I'll undraft, ready for round 3 review. |
|
Everything seems to work fine, so we're good to go :) |
kvark
reviewed
Jan 16, 2021
|
Addressed; Thanks for the detailed reviews :) bors r=kvark |
bors bot
added a commit
to gfx-rs/wgpu-rs
that referenced
this pull request
Jan 16, 2021
715: Add pipeline statistics and timeline queries r=kvark a=cwfitzgerald Blocked on gfx-rs/wgpu#1128. Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
kvark
pushed a commit
to kvark/wgpu
that referenced
this pull request
Jun 3, 2021
715: Add pipeline statistics and timeline queries r=kvark a=cwfitzgerald Blocked on gfx-rs#1128. Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Closes #721
Description
This adds Pipeline Statistics queries and Timeline queries. Shoutout to @z2oh for doing a good chunk of the work to enable this feature.
Currently blocked on both gfx-rs/gfx#3563 and rollup of gfx-hal mutability changes, but is ready to review.
Testing
Tested in various ways on the hello-compute and hello-triangle example, tested validation extensively. Queries will be permanently added to the mipmap example once the wgpu-rs PR is finished.