Skip to content

Enable the non-fill polygon mode feature if requested #1016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 6, 2020

Conversation

kvark
Copy link
Member

@kvark kvark commented Nov 6, 2020

Connections
Follow up to #921

Description
Seeing the validation error on the cube example:

VALIDATION [VUID-VkPipelineRasterizationStateCreateInfo-polygonMode-01413 (-212053721)] : Validation Error: [ VUID-VkPipelineRasterizationStateCreateInfo-polygonMode-01413 ] Object 0: handle = 0x55872ea38860, type = VK_OBJECT_TYPE_DEVICE; | MessageID = 0xf35c5127 | vkCreateGraphicsPipelines parameter, VkPolygonMode pCreateInfos[0]->pRasterizationState->polygonMode cannot be VK_POLYGON_MODE_POINT or VK_POLYGON_MODE_LINE if VkPhysicalDeviceFeatures->fillModeNonSolid is false. The Vulkan spec states: If the non-solid fill modes feature is not enabled, polygonMode must be VK_POLYGON_MODE_FILL (https://www.khronos.org/registry/vulkan/specs/1.2-khr-extensions/html/vkspec.html#VUID-VkPipelineRasterizationStateCreateInfo-polygonMode-01413)
o

Testing
Untested

@kvark kvark requested a review from cwfitzgerald November 6, 2020 00:15
Copy link
Contributor

@monocodus monocodus bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an autogenerated code review.New suggestions: 1

Checker summary (by rust_clippy):
The tool has found 92 warnings, 0 errors.

Co-authored-by: monocodus[bot] <49363530+monocodus[bot]@users.noreply.github.com>
@kvark kvark merged commit 73d3f71 into master Nov 6, 2020
@kvark kvark deleted the kvark-non-polygon branch November 6, 2020 05:32
Copy link
Contributor

@monocodus monocodus bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an autogenerated code review.

Checker summary (by rust_clippy):
The tool has found 92 warnings, 0 errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant