Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

y-flip should require vulkan 1.1 #2475

Closed
m4b opened this issue Feb 12, 2022 · 0 comments · Fixed by #2512
Closed

y-flip should require vulkan 1.1 #2475

m4b opened this issue Feb 12, 2022 · 0 comments · Fixed by #2512
Labels
area: correctness We're behaving incorrectly good first issue Good for newcomers help required We need community help to make this happen.

Comments

@m4b
Copy link
Contributor

m4b commented Feb 12, 2022

Description
Today, whether y-flip is supported (and whether we ignore the adapter) is determined here:

&& phd_capabilities.properties.api_version < vk::API_VERSION_1_2

Specifically, the vulkan 1.2 requirement may be too strict. My reading of https://www.khronos.org/registry/vulkan/specs/1.3-extensions/man/html/VK_AMD_negative_viewport_height.html#_obsoletion_by_vk_khr_maintenance1_and_vulkan_1_1 seems to indicate that vulkan 1.1 is sufficient, and the check at the above location is safe to reduce to 1.1 for conformant drivers.

Repro steps
I hit this running on the panvk driver, which while not conformant, reports 1.1, but does not have the amd extension nor the VK_KHR_maintenance1 extension.

Expected vs observed behavior
Can run wgpu on vulkan 1.1 conformant driver.

@kvark kvark added area: correctness We're behaving incorrectly good first issue Good for newcomers help required We need community help to make this happen. labels Feb 13, 2022
cwfitzgerald pushed a commit that referenced this issue Oct 25, 2023
`Iterator` is a supertrait of `ExactSizeIterator`, so specifying `ExactSizeIterator` is enough.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: correctness We're behaving incorrectly good first issue Good for newcomers help required We need community help to make this happen.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants