This repository was archived by the owner on Jun 18, 2021. It is now read-only.
Unwrap errors from transfer API #430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bors bot
added a commit
to gfx-rs/wgpu
that referenced
this pull request
Jul 11, 2020
773: Error handling for data transfer API r=kvark a=GabrielMajeri **Connections** Work on the error model described in #376 **Description** Removes assertions from the transfer functions, instead returning a custom error type. **Testing** Checked with `player` and `wgpu-rs`: gfx-rs/wgpu-rs#430 Co-authored-by: Gabriel Majeri <gabriel.majeri6@gmail.com>
GabrielMajeri
force-pushed
the
transfer-commands-error-handling
branch
from
05166e9 to
ee3f5d4
Compare
|
I've updated this to use the latest revision of |
GabrielMajeri
force-pushed
the
transfer-commands-error-handling
branch
4 times, most recently
from
b69325e to
79fac64
Compare
bors bot
added a commit
to gfx-rs/wgpu
that referenced
this pull request
Jul 11, 2020
782: Add check while trying to remove uninserted Ids r=kvark a=kunalmohan **Connections** _Link to the issues addressed by this PR, or dependent PRs in other repositories_ An attempt to fix #781 regression from #776 **Description** _Describe what problem this is solving, and how it's solved._ When we used `VecMap`, it simply returned `None` for even out of bounds access to the map (We depended on it returning `None`). After #776 , we get a panic. So adding a simple index check before accessing it fixes this issue. **Testing** _Explain how this change is tested._ Tested on wgpu-rs examples with the changes in gfx-rs/wgpu-rs#430. All examples run fine except the `cube` which segfaults. <!-- Non-trivial functional changes would need to be tested through: - [wgpu-rs](https://github.com/gfx-rs/wgpu-rs) - test the examples. - [wgpu-native](https://github.com/gfx-rs/wgpu-native/) - check the generated C header for sanity. Ideally, a PR needs to link to the draft PRs in these projects with relevant modifications. See #666 for an example. If you can add a unit/integration test here in `wgpu`, that would be best. --> Co-authored-by: Kunal Mohan <kunalmohan99@gmail.com>
GabrielMajeri
force-pushed
the
transfer-commands-error-handling
branch
from
79fac64 to
1381c03
Compare
|
I'm going to mark this as ready for review, because it no longer crashes for me. I've been able to run the examples successfully. |
bors bot
added a commit
that referenced
this pull request
Jul 12, 2020
430: Unwrap errors from transfer API r=kvark a=GabrielMajeri `wgpu-rs` part of gfx-rs/wgpu#773 Co-authored-by: Gabriel Majeri <gabriel.majeri6@gmail.com>
|
Build failed: |
bors bot
added a commit
to gfx-rs/wgpu
that referenced
this pull request
Jul 12, 2020
788: Make register methods public again r=kvark a=kvark Fixup after #783 Should unblock gfx-rs/wgpu-rs#430 Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
|
@GabrielMajeri sorry about that! Should be fixed once gfx-rs/wgpu#788 is merged (and the revision here is updated) |
GabrielMajeri
force-pushed
the
transfer-commands-error-handling
branch
from
1381c03 to
009d062
Compare
|
@kvark No problem, should be all OK now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wgpu-rspart of gfx-rs/wgpu#773