This repository was archived by the owner on Jun 18, 2021. It is now read-only.
Add Extension/Limit Interface #338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
bors bot
added a commit
to gfx-rs/wgpu
that referenced
this pull request
Jun 1, 2020
690: Implement Anisotropic Filtering Extension and Expose Extension Interface r=kvark a=cwfitzgerald **Connections** Resolves #568. **Description** This PR solves two tightly related problems: - Adds the ability to create a sampler with anisotropic filtering - Adds the webgpu interface for getting the limits/extensions on adapters and devies. **Testing** I have tested this against my codebase which uses it. Adding an example in wgpu-rs on how to use extensions/limits would be good, especially as we have native/webgpu extensions, but can come as a future enhancement, once we feel the extension situation has stabilized a bit. **TODO** - [x] Allow wgpu-rs to call limit/extension interface (gfx-rs/wgpu-rs#338) - [ ] Determine how wgpu-native is going to adopt this functionality. - [ ] After discussing #691, what changes need to be made. Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
bors bot
added a commit
to gfx-rs/wgpu
that referenced
this pull request
Jun 1, 2020
690: Implement Anisotropic Filtering Extension and Expose Extension Interface r=kvark a=cwfitzgerald **Connections** Resolves #568. **Description** This PR solves two tightly related problems: - Adds the ability to create a sampler with anisotropic filtering - Adds the webgpu interface for getting the limits/extensions on adapters and devies. **Testing** I have tested this against my codebase which uses it. Adding an example in wgpu-rs on how to use extensions/limits would be good, especially as we have native/webgpu extensions, but can come as a future enhancement, once we feel the extension situation has stabilized a bit. **TODO** - [x] Allow wgpu-rs to call limit/extension interface (gfx-rs/wgpu-rs#338) - [ ] Determine how wgpu-native is going to adopt this functionality. - [ ] After discussing #691, what changes need to be made. Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
cwfitzgerald
force-pushed
the
anisotropic-filtering
branch
from
ee868f1 to
e189d0d
Compare
cwfitzgerald
force-pushed
the
anisotropic-filtering
branch
from
e189d0d to
c4819cc
Compare
kvark
approved these changes
Jun 1, 2020
| @@ -130,6 +130,7 @@ impl framework::Example for Skybox { | |||
| lod_min_clamp: 0.0, | |||
| lod_max_clamp: 100.0, | |||
| compare: wgpu::CompareFunction::Undefined, | |||
| anisotropy_clamp: 1, | |||
There was a problem hiding this comment.
I think we should change most (if not all) sampler descriptors to end with .. Default::default(). That would be more future proof, match the web better, and avoid exposing stuff that is not relevant
There was a problem hiding this comment.
I agree. Should I change this in this PR? Or should that be separate?
There was a problem hiding this comment.
let's have this merged, the PR just continues the convention of the old code, it's not required to change that
bors bot
added a commit
that referenced
this pull request
Jun 3, 2020
345: Rustify the example's use of Extensions and SamplerDescriptor r=kvark a=cwfitzgerald Implements gfx-rs/wgpu#696. This didn't change any content from #338, just interface, but I tested a couple examples and it seems to work okay. Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
bors bot
added a commit
that referenced
this pull request
Jun 3, 2020
345: Rustify the example's use of Extensions and SamplerDescriptor r=kvark a=cwfitzgerald Implements gfx-rs/wgpu#696. This didn't change any content from #338, just interface, but I tested a couple examples and it seems to work okay. Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to gfx-rs/wgpu#690.
This forwards the extension/limit access interface into wgpu-rs.
It appears that the web-sys doesn't actually implement any of the methods we need, so I had them return the defaults.
Device::limitsexists, but it returnsObjectnotGpuLimits, so doesn't appear usable.