This repository was archived by the owner on Jan 29, 2025. It is now read-only.
[glsl/spv-out] Cull functions that should not be available for a given stage #2531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teoxoy
force-pushed
the
cull-functions
branch
from
dbb50bd to
bc73279
Compare
jimblandy
approved these changes
Oct 16, 2023
Member
jimblandy
left a comment
jimblandy
left a comment
There was a problem hiding this comment.
Looks good to me, but see if the comments I suggested are right.
jimblandy
reviewed
Oct 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2524
Done it for SPIR-V as well since the ability to separate entry points (#1329) was added to work around driver bugs and I can imagine them misbehaving in this case as well.