glsl-out: Fix feature search in expressions #1887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gordon-F
reviewed
May 3, 2022
JCapucho
force-pushed
the
glsl-features-fix
branch
from
f497b7b
to
92f94a7
Compare
Gordon-F
suggested changes
May 3, 2022
It was also searching in all entry points instead of only in the current one. All samples queries need the ARB_shader_texture_image_samples extension so we need to check if any samples queries are made and if so request the extension.
JCapucho
force-pushed
the
glsl-features-fix
branch
from
92f94a7
to
4d06b77
Compare
Gordon-F
approved these changes
May 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fma wasn't being searched in case it wasn't supported which is the
opposite of what we want since if it's used we want to error if it isn't
supported.
It was also searching in all entry points instead of only in the current
one.
All samples queries need the ARB_shader_texture_image_samples extension
so we need to check if any samples queries are made and if so request
the extension.