Fix validation errors in quad example #3043
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demurgos
force-pushed
the
quad-validation-error
branch
from
c94d227 to
dcf3bd7
Compare
demurgos
changed the title
kvark
requested changes
Oct 15, 2019
rukai
reviewed
Oct 15, 2019
| .expect("Failed to create an instance!"); | ||
| let surface = instance.create_surface(&window).expect("Failed to create a surface!"); | ||
| let adapters = instance.enumerate_adapters(); | ||
| // Return `window` so it is not dropped: dropping it invalidates `surface`. |
This commit fixes the Vulkan validation errors caused by not destroying the swapchain. It also fixes a typo and adds a small comment explaining why `main` extends the lifetime of `window` beyond its initial scope.
demurgos
force-pushed
the
quad-validation-error
branch
from
dcf3bd7 to
8e8d801
Compare
bors bot
added a commit
that referenced
this pull request
Oct 15, 2019
3043: Fix validation errors in quad example r=kvark a=demurgos PR checklist: - [x] `make` succeeds (on *nix) - [x] `make reftests` succeeds - [x] tested examples with the following backends: vulkan, gl (wasm) - [x] `rustfmt` run on changed code Fix validation errors in quad example This commit fixes the Vulkan validation errors for the `quad` example: - The framebuffer is destroyed without waiting for the command buffer to be executed. - The swapchain is not destroyed. This commit also adds a small comment explaining why `main` extends the lifetime of `window` beyond its initial scope. Co-authored-by: Charles Samborski <demurgos@demurgos.net>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist:
makesucceeds (on *nix)make reftestssucceedsrustfmtrun on changed codeFix validation errors in quad example
This commit fixes the Vulkan validation errors for the
quadexample:This commit also adds a small comment explaining why
mainextends the lifetime ofwindowbeyond its initial scope.