React to HW-api changes #46

gfoidl · 2018-12-25T10:59:05Z

The HW-apis changed for netcoreapp3.0, this is the reaction for this.

Fixes #15

gfoidl

All the #ifs look a bit messy. Maybe separte to files?

.azure/pipelines/ci.yml

source/gfoidl.Base64/Internal/Base64EncoderImpl.cs

codecov-io · 2018-12-25T11:02:17Z

Codecov Report

Merging #46 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master    #46    +/-   ##
======================================
  Coverage     100%   100%            
======================================
  Files          10     10            
  Lines        2068   2207   +139     
======================================
+ Hits         2068   2207   +139

Impacted Files	Coverage Δ
...idl.Base64/Internal/Base64Encoder/Base64Encoder.cs	`100% <100%> (ø)`	⬆️
source/gfoidl.Base64/Internal/Avx2Helper.cs	`100% <100%> (ø)`	⬆️
...e64/Internal/Base64Encoder/Base64Encoder.Encode.cs	`100% <100%> (ø)`	⬆️
...se64/Internal/Base64UrlEncoder/Base64UrlEncoder.cs	`100% <100%> (ø)`	⬆️
...e64/Internal/Base64Encoder/Base64Encoder.Decode.cs	`100% <100%> (ø)`	⬆️
source/gfoidl.Base64/Internal/Base64EncoderImpl.cs	`100% <100%> (ø)`	⬆️
...ternal/Base64UrlEncoder/Base64UrlEncoder.Encode.cs	`100% <100%> (ø)`	⬆️
...ternal/Base64UrlEncoder/Base64UrlEncoder.Decode.cs	`100% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c8c69f...4487852. Read the comment docs.

gfoidl · 2018-12-25T11:34:09Z

windows builds fail due

Test run for D:\a\1\s\tests\gfoidl.Base64.Tests\bin\Release\net471\gfoidl.Base64.Tests.dll(.NETFramework,Version=v4.7.1)
Microsoft (R) Test Execution Command Line Tool Version 15.9.0
Copyright (c) Microsoft Corporation.  All rights reserved.

Starting test execution, please wait...
Failed   Issue_32_EncodedLength_is_lt_4___throws_ArgumentOutOfRange(1)
Error Message:
   Expected string length 119 but was 120. Strings differ at index 100.
  Expected: "...e64 standard. It must be >= 4.\r\nParametername: encodedLength"
  But was:  "...e64 standard. It must be >= 4.\r\nParameter name: encodedLength"
  ---------------------------------------------------------^

Stack Trace:
   at gfoidl.Base64.Tests.Internal.Base64EncoderTests.GetDecodedLength`1.<>c__DisplayClass4_0.<Issue_32_EncodedLength_is_lt_4___throws_ArgumentOutOfRange>b__1() in D:\a\1\s\tests\gfoidl.Base64.Tests\Internal\Base64EncoderTests\GetDecodedLength.cs:line 101
   at NUnit.Framework.Assert.Multiple(TestDelegate testDelegate)
   at gfoidl.Base64.Tests.Internal.Base64EncoderTests.GetDecodedLength`1.Issue_32_EncodedLength_is_lt_4___throws_ArgumentOutOfRange(Int32 encodedLength) in D:\a\1\s\tests\gfoidl.Base64.Tests\Internal\Base64EncoderTests\GetDecodedLength.cs:line 102

Failed   Issue_32_EncodedLength_is_lt_4___throws_ArgumentOutOfRange(2)
Error Message:
   Expected string length 119 but was 120. Strings differ at index 100.
  Expected: "...e64 standard. It must be >= 4.\r\nParametername: encodedLength"
  But was:  "...e64 standard. It must be >= 4.\r\nParameter name: encodedLength"
  ---------------------------------------------------------^

Stack Trace:
   at gfoidl.Base64.Tests.Internal.Base64EncoderTests.GetDecodedLength`1.<>c__DisplayClass4_0.<Issue_32_EncodedLength_is_lt_4___throws_ArgumentOutOfRange>b__1() in D:\a\1\s\tests\gfoidl.Base64.Tests\Internal\Base64EncoderTests\GetDecodedLength.cs:line 101
   at NUnit.Framework.Assert.Multiple(TestDelegate testDelegate)
   at gfoidl.Base64.Tests.Internal.Base64EncoderTests.GetDecodedLength`1.Issue_32_EncodedLength_is_lt_4___throws_ArgumentOutOfRange(Int32 encodedLength) in D:\a\1\s\tests\gfoidl.Base64.Tests\Internal\Base64EncoderTests\GetDecodedLength.cs:line 102

Failed   Issue_32_EncodedLength_is_lt_4___throws_ArgumentOutOfRange(3)
Error Message:
   Expected string length 119 but was 120. Strings differ at index 100.
  Expected: "...e64 standard. It must be >= 4.\r\nParametername: encodedLength"
  But was:  "...e64 standard. It must be >= 4.\r\nParameter name: encodedLength"
  ---------------------------------------------------------^

Stack Trace:
   at gfoidl.Base64.Tests.Internal.Base64EncoderTests.GetDecodedLength`1.<>c__DisplayClass4_0.<Issue_32_EncodedLength_is_lt_4___throws_ArgumentOutOfRange>b__1() in D:\a\1\s\tests\gfoidl.Base64.Tests\Internal\Base64EncoderTests\GetDecodedLength.cs:line 101
   at NUnit.Framework.Assert.Multiple(TestDelegate testDelegate)
   at gfoidl.Base64.Tests.Internal.Base64EncoderTests.GetDecodedLength`1.Issue_32_EncodedLength_is_lt_4___throws_ArgumentOutOfRange(Int32 encodedLength) in D:\a\1\s\tests\gfoidl.Base64.Tests\Internal\Base64EncoderTests\GetDecodedLength.cs:line 102

Failed   Issue_32_EncodedLength_is_lt_4___throws_ArgumentOutOfRange(1)
Error Message:
   Expected string length 119 but was 120. Strings differ at index 100.
  Expected: "...e64 standard. It must be >= 4.\r\nParametername: encodedLength"
  But was:  "...e64 standard. It must be >= 4.\r\nParameter name: encodedLength"
  ---------------------------------------------------------^

Stack Trace:
   at gfoidl.Base64.Tests.Internal.Base64EncoderTests.GetDecodedLength`1.<>c__DisplayClass4_0.<Issue_32_EncodedLength_is_lt_4___throws_ArgumentOutOfRange>b__1() in D:\a\1\s\tests\gfoidl.Base64.Tests\Internal\Base64EncoderTests\GetDecodedLength.cs:line 101
   at NUnit.Framework.Assert.Multiple(TestDelegate testDelegate)
   at gfoidl.Base64.Tests.Internal.Base64EncoderTests.GetDecodedLength`1.Issue_32_EncodedLength_is_lt_4___throws_ArgumentOutOfRange(Int32 encodedLength) in D:\a\1\s\tests\gfoidl.Base64.Tests\Internal\Base64EncoderTests\GetDecodedLength.cs:line 102

Failed   Issue_32_EncodedLength_is_lt_4___throws_ArgumentOutOfRange(2)
Error Message:
   Expected string length 119 but was 120. Strings differ at index 100.
  Expected: "...e64 standard. It must be >= 4.\r\nParametername: encodedLength"
  But was:  "...e64 standard. It must be >= 4.\r\nParameter name: encodedLength"
  ---------------------------------------------------------^

Stack Trace:
   at gfoidl.Base64.Tests.Internal.Base64EncoderTests.GetDecodedLength`1.<>c__DisplayClass4_0.<Issue_32_EncodedLength_is_lt_4___throws_ArgumentOutOfRange>b__1() in D:\a\1\s\tests\gfoidl.Base64.Tests\Internal\Base64EncoderTests\GetDecodedLength.cs:line 101
   at NUnit.Framework.Assert.Multiple(TestDelegate testDelegate)
   at gfoidl.Base64.Tests.Internal.Base64EncoderTests.GetDecodedLength`1.Issue_32_EncodedLength_is_lt_4___throws_ArgumentOutOfRange(Int32 encodedLength) in D:\a\1\s\tests\gfoidl.Base64.Tests\Internal\Base64EncoderTests\GetDecodedLength.cs:line 102

Failed   Issue_32_EncodedLength_is_lt_4___throws_ArgumentOutOfRange(3)
Error Message:
   Expected string length 119 but was 120. Strings differ at index 100.
  Expected: "...e64 standard. It must be >= 4.\r\nParametername: encodedLength"
  But was:  "...e64 standard. It must be >= 4.\r\nParameter name: encodedLength"
  ---------------------------------------------------------^

Stack Trace:
   at gfoidl.Base64.Tests.Internal.Base64EncoderTests.GetDecodedLength`1.<>c__DisplayClass4_0.<Issue_32_EncodedLength_is_lt_4___throws_ArgumentOutOfRange>b__1() in D:\a\1\s\tests\gfoidl.Base64.Tests\Internal\Base64EncoderTests\GetDecodedLength.cs:line 101
   at NUnit.Framework.Assert.Multiple(TestDelegate testDelegate)
   at gfoidl.Base64.Tests.Internal.Base64EncoderTests.GetDecodedLength`1.Issue_32_EncodedLength_is_lt_4___throws_ArgumentOutOfRange(Int32 encodedLength) in D:\a\1\s\tests\gfoidl.Base64.Tests\Internal\Base64EncoderTests\GetDecodedLength.cs:line 102

Failed   EncodedLength_is_negative___throws_ArgumentOutOfRange
Error Message:
   Expected string length 119 but was 120. Strings differ at index 100.
  Expected: "...e64 standard. It must be >= 4.\r\nParametername: encodedLength"
  But was:  "...e64 standard. It must be >= 4.\r\nParameter name: encodedLength"
  ---------------------------------------------------------^

Stack Trace:
   at gfoidl.Base64.Tests.Internal.Base64EncoderTests.GetMaxDecodedLength.<>c__DisplayClass0_0.<EncodedLength_is_negative___throws_ArgumentOutOfRange>b__1() in D:\a\1\s\tests\gfoidl.Base64.Tests\Internal\Base64EncoderTests\GetMaxDecodedLength.cs:line 26
   at NUnit.Framework.Assert.Multiple(TestDelegate testDelegate)
   at gfoidl.Base64.Tests.Internal.Base64EncoderTests.GetMaxDecodedLength.EncodedLength_is_negative___throws_ArgumentOutOfRange() in D:\a\1\s\tests\gfoidl.Base64.Tests\Internal\Base64EncoderTests\GetMaxDecodedLength.cs:line 27

Cf. #46 (comment)

gfoidl · 2018-12-25T15:01:17Z

windows build fail due

Test run for D:\a\1\s\tests\gfoidl.Base64.Tests\bin\Release\net471\gfoidl.Base64.Tests.dll(.NETFramework,Version=v4.7.1)
Microsoft (R) Test Execution Command Line Tool Version 15.9.0
Copyright (c) Microsoft Corporation.  All rights reserved.

Starting test execution, please wait...
Failed   Default___base64_is_used
Error Message:
 System.TypeInitializationException : The type initializer for 'Coverlet.Core.Instrumentation.Tracker.gfoidl.Base64_ca953f4c-294c-4af4-87e9-cce811fc9369' threw an exception.
  ----> System.IO.FileNotFoundException : Could not load file or assembly 'System.Runtime.Extensions, Version=4.2.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies. The system cannot find the file specified.
Stack Trace:
   at Coverlet.Core.Instrumentation.Tracker.gfoidl.Base64_ca953f4c-294c-4af4-87e9-cce811fc9369.RecordHit(Int32 )
   at gfoidl.Base64.Base64.get_Default()
   at gfoidl.Base64.Tests.Base64Tests.Default`1.Default___base64_is_used() in D:\a\1\s\tests\gfoidl.Base64.Tests\Base64Tests\Default.cs:line 16
--FileNotFoundException
   at Coverlet.Core.Instrumentation.Tracker.gfoidl.Base64_ca953f4c-294c-4af4-87e9-cce811fc9369..cctor()
Failed   Default_with_buffers___base64_is_used
Error Message:
 System.TypeInitializationException : The type initializer for 'Coverlet.Core.Instrumentation.Tracker.gfoidl.Base64_ca953f4c-294c-4af4-87e9-cce811fc9369' threw an exception.
  ----> System.IO.FileNotFoundException : Could not load file or assembly 'System.Runtime.Extensions, Version=4.2.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies. The system cannot find the file specified.
Stack Trace:
   at Coverlet.Core.Instrumentation.Tracker.gfoidl.Base64_ca953f4c-294c-4af4-87e9-cce811fc9369.RecordHit(Int32 )
   at gfoidl.Base64.Base64.get_Default()
   at gfoidl.Base64.Tests.Base64Tests.Default`1.Default_with_buffers___base64_is_used() in D:\a\1\s\tests\gfoidl.Base64.Tests\Base64Tests\Default.cs:line 28
--FileNotFoundException
   at Coverlet.Core.Instrumentation.Tracker.gfoidl.Base64_ca953f4c-294c-4af4-87e9-cce811fc9369..cctor()
...

gfoidl · 2018-12-25T15:36:07Z

For the build failure of #46 (comment):
it works with coverlet 1.3.0, but not with coverlet 1.4.0 (latest as of now) -> coverlet-coverage/coverlet#274

Cf. #46 (comment)

gfoidl · 2018-12-25T16:19:24Z

Will resolve #46 (comment) in a new PR, to keep the changes clean.

gfoidl added 2 commits December 24, 2018 14:46

Updated CI to latest SDK-preview

82c64e0

netcoreapp3.0 API changes

1712243

gfoidl added the simd label Dec 25, 2018

gfoidl added this to the v1.0.0 milestone Dec 25, 2018

gfoidl self-assigned this Dec 25, 2018

gfoidl commented Dec 25, 2018

View reviewed changes

.azure/pipelines/ci.yml Show resolved Hide resolved

source/gfoidl.Base64/Internal/Base64EncoderImpl.cs Show resolved Hide resolved

Fixed win-build failure

d29cfa9

Cf. #46 (comment)

Fixed coverlet bug by using specific version

4487852

Cf. #46 (comment)

gfoidl merged commit 2534fb9 into master Dec 25, 2018

gfoidl deleted the coreclr-reaction branch December 25, 2018 16:19

gfoidl mentioned this pull request Dec 25, 2018

Separate files instead #ifdefs #49

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

React to HW-api changes #46

React to HW-api changes #46

gfoidl commented Dec 25, 2018

gfoidl left a comment

codecov-io commented Dec 25, 2018 •

edited

Loading

gfoidl commented Dec 25, 2018

gfoidl commented Dec 25, 2018

gfoidl commented Dec 25, 2018 •

edited

Loading

gfoidl commented Dec 25, 2018

React to HW-api changes #46

React to HW-api changes #46

Conversation

gfoidl commented Dec 25, 2018

gfoidl left a comment

Choose a reason for hiding this comment

codecov-io commented Dec 25, 2018 • edited Loading

Codecov Report

gfoidl commented Dec 25, 2018

gfoidl commented Dec 25, 2018

gfoidl commented Dec 25, 2018 • edited Loading

gfoidl commented Dec 25, 2018

codecov-io commented Dec 25, 2018 •

edited

Loading

gfoidl commented Dec 25, 2018 •

edited

Loading