Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ReadOnlySequence as input #106

Merged
merged 10 commits into from
Nov 17, 2019
Merged

Support ReadOnlySequence as input #106

merged 10 commits into from
Nov 17, 2019

Conversation

gfoidl
Copy link
Owner

@gfoidl gfoidl commented Nov 9, 2019

Fixes #61

@gfoidl gfoidl added the enhancement New feature or request label Nov 9, 2019
@gfoidl gfoidl added this to the v1.1.0 milestone Nov 9, 2019
@gfoidl gfoidl self-assigned this Nov 9, 2019
@gfoidl
Copy link
Owner Author

gfoidl commented Nov 9, 2019

@ycrumeyrolle I gave the ReadOnlySequence-thing a shot, please have a look.

@gfoidl
Copy link
Owner Author

gfoidl commented Nov 9, 2019

A preview package is here -> https://www.myget.org/feed/gfoidl/package/nuget/gfoidl.Base64/1.1.0-preview-1

@gfoidl @ycrumeyrolle
Update source/gfoidl.Base64/ThrowHelper.cs
91d6cdc 
Co-Authored-By: Yann Crumeyrolle <ycrumeyrolle@free.fr>
@ycrumeyrolle
Copy link
Contributor

Looks good

@gfoidl
Copy link
Owner Author

gfoidl commented Nov 17, 2019 •
edited
Loading

Thanks for having a look.
I'll have another look too, then I'll merge it (later today).

@gfoidl gfoidl merged commit 3ecee89 into master Nov 17, 2019
@gfoidl gfoidl deleted the rosequence branch November 17, 2019 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ycrumeyrolle ycrumeyrolle ycrumeyrolle left review comments

Assignees

@gfoidl gfoidl

Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.

[Proposal] Support ReadOnlySequence as input
2 participants
@gfoidl @ycrumeyrolle