Skip to content

Allow user to specify custom S3 endpoint #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Allow user to specify custom S3 endpoint #67

wants to merge 2 commits into from

Conversation

williamshen-nz
Copy link
Collaborator

@williamshen-nz williamshen-nz commented Nov 23, 2022 •
edited
Loading

So we can use ceph

ML_LOGGER_S3_ENDPOINT=https:///ceph.blahblah.com

Uses default endpoint if None

@geyang
Copy link
Owner

geyang commented Nov 23, 2022

Looks great! can you add this as an input variable to the ML_Logger constructor, so that it could be passed in programmatically?

And make this an attribute to the logger.

@geyang
Copy link
Owner

geyang commented Feb 12, 2023

@williamshen-nz let's get this one finished

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geyang geyang Awaiting requested review from geyang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@williamshen-nz @geyang