Skip to content

Commit

Permalink
chore: rename angular.bind to angular.bind.js
Browse files Browse the repository at this point in the history
Some internal tests were failing since `.bind` is a JS file which
is expected to have a `.js` file name suffix.
  • Loading branch information
matsko committed Aug 12, 2015
1 parent 92e41ac commit cf28c1a
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 8 deletions.
8 changes: 6 additions & 2 deletions Gruntfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ module.exports = function(grunt) {
files: { src: 'test/**/*.js' },
},
ng: {
files: { src: files['angularSrc'].concat('!src/angular.bind') },
files: { src: files['angularSrc'].concat('!src/angular.bind.js') },
},
ngAnimate: {
files: { src: 'src/ngAnimate/**/*.js' },
Expand Down Expand Up @@ -156,7 +156,11 @@ module.exports = function(grunt) {
},

jscs: {
src: ['src/**/*.js', 'test/**/*.js'],
src: [
'src/**/*.js',
'test/**/*.js',
'!src/angular.bind.js' // we ignore this file since contains an early return statement
],
options: {
config: ".jscsrc"
}
Expand Down
6 changes: 3 additions & 3 deletions angularFiles.js
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ var angularFiles = {
'src/ng/directive/select.js',
'src/ng/directive/style.js',
'src/ng/directive/validators.js',
'src/angular.bind',
'src/angular.bind.js',
'src/publishExternalApis.js',
'src/ngLocale/angular-locale_en-us.js'
],
Expand Down Expand Up @@ -191,7 +191,7 @@ var angularFiles = {
'test/jquery_alias.js',
'src/angular-bootstrap.js',
'src/ngScenario/angular-bootstrap.js',
'src/angular.bind'
'src/angular.bind.js'
],

'karmaScenario': [
Expand Down Expand Up @@ -227,7 +227,7 @@ var angularFiles = {
'src/angular-bootstrap.js',
'src/ngScenario/angular-bootstrap.js',
'test/jquery_remove.js',
'src/angular.bind'
'src/angular.bind.js'
]
};

Expand Down
2 changes: 1 addition & 1 deletion docs/config/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ module.exports = new Package('angularjs', [

readFilesProcessor.basePath = path.resolve(__dirname,'../..');
readFilesProcessor.sourceFiles = [
{ include: 'src/**/*.js', basePath: 'src' },
{ include: 'src/**/*.js', exclude: 'src/angular.bind.js', basePath: 'src' },
{ include: 'docs/content/**/*.ngdoc', basePath: 'docs/content' }
];

Expand Down
5 changes: 3 additions & 2 deletions docs/gulpfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ var outputFolder = '../build/docs';
var bowerFolder = 'bower_components';

var src = 'app/src/**/*.js';
var ignoredFiles = '!src/angular.bind.js';
var assets = 'app/assets/**/*';


Expand Down Expand Up @@ -50,7 +51,7 @@ gulp.task('build-app', function() {
var minFile = 'docs.min.js';
var folder = outputFolder + '/js/';

return gulp.src(src)
return gulp.src([src, ignoredFiles])
.pipe(sourcemaps.init())
.pipe(concat(file))
.pipe(gulp.dest(folder))
Expand Down Expand Up @@ -107,5 +108,5 @@ gulp.task('jshint', ['doc-gen'], function() {
gulp.task('default', ['assets', 'doc-gen', 'build-app', 'jshint']);

gulp.task('watch', function() {
gulp.watch([src, assets], ['assets', 'build-app']);
gulp.watch([src, ignoredFiles, assets], ['assets', 'build-app']);
});
File renamed without changes.

0 comments on commit cf28c1a

Please sign in to comment.