-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update reranker limits #203
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 898e139 in 18 seconds
More details
- Looked at
452
lines of code in3
files - Skipped
1
files when reviewing. - Skipped posting
6
drafted comments based on config settings.
1. graphiti_core/search/search.py:57
- Draft comment:
The indentation level for function parameters has been changed to 8 spaces. Consider reverting to 4 spaces for consistency with PEP 8 guidelines. This issue is present in multiple functions in this file. - Reason this comment was not posted:
Confidence changes required:50%
The indentation in the function definitions has been changed from 4 spaces to 8 spaces. This is inconsistent with the typical Python style guide (PEP 8) which recommends 4 spaces per indentation level. This change affects readability and consistency across the codebase.
2. graphiti_core/search/search_utils.py:64
- Draft comment:
The indentation level for function parameters has been changed to 8 spaces. Consider reverting to 4 spaces for consistency with PEP 8 guidelines. This issue is present in multiple functions in this file. - Reason this comment was not posted:
Confidence changes required:50%
The indentation in the function definitions has been changed from 4 spaces to 8 spaces. This is inconsistent with the typical Python style guide (PEP 8) which recommends 4 spaces per indentation level. This change affects readability and consistency across the codebase.
3. graphiti_core/search/search_utils.py:698
- Draft comment:
Usinglist(set(...))
to remove duplicates changes the order of elements, which might not be intended. Consider using anOrderedDict
to maintain order while removing duplicates. - Reason this comment was not posted:
Confidence changes required:50%
In themaximal_marginal_relevance
function, the use oflist(set(...))
to remove duplicates changes the order of elements, which might not be intended. This could affect the ranking order of the results.
4. graphiti_core/search/search.py:57
- Draft comment:
Function parameters should be aligned consistently. Adjust the indentation to align parameters with the opening parenthesis. - Reason this comment was not posted:
Confidence changes required:80%
The code has inconsistent indentation for function parameters, which is not idiomatic.
5. graphiti_core/search/search_utils.py:64
- Draft comment:
Function parameters should be aligned consistently. Adjust the indentation to align parameters with the opening parenthesis. - Reason this comment was not posted:
Confidence changes required:80%
The code has inconsistent indentation for function parameters, which is not idiomatic.
6. pyproject.toml:1
- Draft comment:
Ensure consistent indentation for all sections in the file. - Reason this comment was not posted:
Confidence changes required:50%
The code has inconsistent indentation for function parameters, which is not idiomatic.
Workflow ID: wflow_GpQ1nmY4a5Nw7Iu6
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 34b0b0b in 23 seconds
More details
- Looked at
362
lines of code in2
files - Skipped
0
files when reviewing. - Skipped posting
4
drafted comments based on config settings.
1. graphiti_core/search/search.py:119
- Draft comment:
Consider adding the RRF reranker to thecommunity_search
function for consistency withnode_search
andedge_search
. - Reason this comment was not posted:
Confidence changes required:50%
The PR introduces a new RRF reranker in thenode_search
andedge_search
functions. However, thecommunity_search
function does not include this new reranker, which might be an oversight if the intent was to apply RRF consistently across all search functions.
2. graphiti_core/search/search_utils.py:230
- Draft comment:
Ensure thelimit
parameter is applied in the Cypher query to avoid large result sets. - Reason this comment was not posted:
Confidence changes required:80%
The PR modifies theedge_bfs_search
andnode_bfs_search
functions to include alimit
parameter. However, thelimit
parameter is not used in the Cypher query withinedge_bfs_search
, which could lead to performance issues if the result set is large.
3. graphiti_core/search/search_utils.py:621
- Draft comment:
Therrf
function is not immediately clear in its purpose. Consider adding a comment explaining its role in the code. - Reason this comment was not posted:
Confidence changes required:50%
The code is missing a comment explaining the purpose of therrf
function, which is not immediately clear from the code itself.
4. graphiti_core/search/search_utils.py:683
- Draft comment:
Themaximal_marginal_relevance
function is not immediately clear in its purpose. Consider adding a comment explaining its role in the code. - Reason this comment was not posted:
Confidence changes required:50%
The code is missing a comment explaining the purpose of themaximal_marginal_relevance
function, which is not immediately clear from the code itself.
Workflow ID: wflow_BxySWMF6aFFnJfnX
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 60c939e in 24 seconds
More details
- Looked at
31
lines of code in2
files - Skipped
0
files when reviewing. - Skipped posting
3
drafted comments based on config settings.
1. graphiti_core/embedder/openai.py:45
- Draft comment:
Renaminginput
toinput_data
avoids shadowing the built-ininput
function, which is a good practice. Ensure this change is consistently applied across the codebase. - Reason this comment was not posted:
Confidence changes required:10%
The change frominput
toinput_data
is consistent across both files and aligns with Python's best practices to avoid using built-in names as variable names.
2. graphiti_core/embedder/voyage.py:44
- Draft comment:
Renaminginput
toinput_data
avoids shadowing the built-ininput
function, which is a good practice. Ensure this change is consistently applied across the codebase. - Reason this comment was not posted:
Confidence changes required:10%
The change frominput
toinput_data
is consistent across both files and aligns with Python's best practices to avoid using built-in names as variable names.
3. graphiti_core/embedder/openai.py:44
- Draft comment:
Functioncreate
should have a more descriptive name to indicate its purpose, such ascreate_embedding
. This applies to the same function invoyage.py
. - Reason this comment was not posted:
Confidence changes required:50%
The code in both files is mostly fine, but there is a minor issue with the function naming pattern.
Workflow ID: wflow_WinEi0Ul6ILIytS1
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 6bc0413 in 10 seconds
More details
- Looked at
22
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
2
drafted comments based on config settings.
1. graphiti_core/embedder/voyage.py:53
- Draft comment:
The check for empty strings ininput_list
is redundant since it's already done in the previous list comprehension. You can remove this line. - Reason this comment was not posted:
Confidence changes required:50%
The check for empty strings in input_list is redundant since it's already done in the previous list comprehension.
2. graphiti_core/embedder/voyage.py:49
- Draft comment:
The list comprehension on line 49 and line 51 can be combined with the one on line 53 to avoid repetition and make the code more DRY. - Reason this comment was not posted:
Confidence changes required:80%
The code is mostly fine, but there are some improvements needed for idiomatic Python and DRY principles.
Workflow ID: wflow_gzXJmA7T77aMLeTe
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Important
Update reranker limits, add preliminary RRF reranker, and update version and dependencies.
edge_search
,node_search
, andcommunity_search
insearch.py
.node_search
andedge_search
.edge_bfs_search
andnode_bfs_search
to include alimit
parameter insearch_utils.py
.input
toinput_data
increate()
inopenai.py
andvoyage.py
.pyproject.toml
from0.3.17
to0.3.18
.openai
dependency to^1.52.2
andruff
to^0.7.1
inpyproject.toml
.This description was created by for 6bc0413. It will automatically update as commits are pushed.