Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZEPAI-676: Remove fuzzy query in fulltext search to avoid errors with large queries #192

Merged
merged 2 commits into from
Oct 19, 2024

Conversation

prasmussen15
Copy link
Collaborator

@prasmussen15 prasmussen15 commented Oct 19, 2024

Important

Remove fuzzy query from fulltext_query() in search_utils.py to prevent errors with large queries.

  • Behavior:
    • Removed fuzzy query component from fulltext_query() in search_utils.py.
    • Simplifies query by using lucene_sanitize(query) instead of lucene_sanitize(query) + '~'.
  • Functions:
    • fulltext_query() no longer appends ~ to the sanitized query string.
  • Misc:
    • Update version in pyproject.toml from 0.3.11 to 0.3.12.

This description was created by Ellipsis for 62c9746. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 33884dd in 10 seconds

More details
  • Looked at 15 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. graphiti_core/search/search_utils.py:52
  • Draft comment:
    The variable fuzzy_query is misleading since the fuzzy query functionality has been removed. Consider renaming it to fulltext_query or lucene_query for clarity. This applies to other instances where fuzzy_query is used, such as in node_fulltext_search and community_fulltext_search.
  • Reason this comment was not posted:
    Confidence changes required: 80%
    The PR removes the fuzzy query from the fulltext search, but the variable name fuzzy_query is still used in several places, which can be misleading.
2. graphiti_core/search/search_utils.py:52
  • Draft comment:
    The variable lucene_query is a good choice for naming, as it accurately describes the sanitized query. Ensure consistent naming across similar functions.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The code is mostly well-structured, but there are some issues with variable naming and DRY principle.

Workflow ID: wflow_n6tfCKpbodaGX0Df


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@prasmussen15 prasmussen15 changed the title Remove fuzzy query in fulltext search to avoid errors with large queries ZEPAI-676: Remove fuzzy query in fulltext search to avoid errors with large queries Oct 19, 2024
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 62c9746 in 7 seconds

More details
  • Looked at 12 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. pyproject.toml:3
  • Draft comment:
    The version update from 0.3.11 to 0.3.12 is consistent with the PR description. Ensure that this version bump is reflected in any related documentation or release notes.
  • Reason this comment was not posted:
    Confidence changes required: 33%
    The version update in the pyproject.toml file is consistent with the PR description, which mentions a version bump from 0.3.11 to 0.3.12. This is a minor version update, likely due to the removal of the fuzzy query feature.
2. pyproject.toml:3
  • Draft comment:
    Ensure that the version number is updated consistently across all relevant files and documentation.
  • Reason this comment was not posted:
    Confidence changes required: 33%
    The pyproject.toml file does not require a copyright notice, and there are no other issues related to the rules provided.

Workflow ID: wflow_H8WeuiHuZQRuI1uT


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@prasmussen15 prasmussen15 merged commit 737a3bc into main Oct 19, 2024
7 checks passed
@prasmussen15 prasmussen15 deleted the remove-fuzzy-search branch October 19, 2024 15:35
@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants