Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix embedding_model_name not work #188

Closed
wants to merge 2 commits into from

Conversation

ArnoChenFx
Copy link
Contributor

@ArnoChenFx ArnoChenFx commented Oct 11, 2024

Important

Fixes issue in zep_graphiti.py where embedding_model_name was not being set in get_graphiti().

  • Behavior:
    • Fixes issue where embedding_model_name was not being set in get_graphiti() in zep_graphiti.py.
    • Adds condition to set client.embedder.config.embedding_model if settings.embedding_model_name is provided.

This description was created by Ellipsis for 28348bc. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 28348bc in 11 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. server/graph_service/zep_graphiti.py:87
  • Draft comment:
    Ensure that client.embedder is initialized before accessing client.embedder.config.embedding_model to avoid potential AttributeError. This applies to the newly added code for embedding_model_name.
  • Reason this comment was not posted:
    Confidence changes required: 80%
    The PR adds a check for embedding_model_name in the get_graphiti function, which is consistent with the existing checks for other settings. This ensures that the embedding_model_name is set if provided in the settings.
2. server/graph_service/zep_graphiti.py:86
  • Draft comment:
    The added code is straightforward and does not require additional comments.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The code block added in the PR is straightforward and does not require additional comments. It is self-explanatory and follows the existing pattern in the function.

Workflow ID: wflow_SolrOeBujRsw8Y1d


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

github-actions bot commented Oct 11, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@ArnoChenFx
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

fix typecheck

fix lint
@paul-paliychuk
Copy link
Collaborator

@ArnoChenFx Closing as not planned. Thank you for contribution.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants