-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix embedding_model_name not work #188
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 28348bc in 11 seconds
More details
- Looked at
13
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
2
drafted comments based on config settings.
1. server/graph_service/zep_graphiti.py:87
- Draft comment:
Ensure thatclient.embedder
is initialized before accessingclient.embedder.config.embedding_model
to avoid potentialAttributeError
. This applies to the newly added code forembedding_model_name
. - Reason this comment was not posted:
Confidence changes required:80%
The PR adds a check forembedding_model_name
in theget_graphiti
function, which is consistent with the existing checks for other settings. This ensures that theembedding_model_name
is set if provided in the settings.
2. server/graph_service/zep_graphiti.py:86
- Draft comment:
The added code is straightforward and does not require additional comments. - Reason this comment was not posted:
Confidence changes required:0%
The code block added in the PR is straightforward and does not require additional comments. It is self-explanatory and follows the existing pattern in the function.
Workflow ID: wflow_SolrOeBujRsw8Y1d
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
28348bc
to
f2c502f
Compare
fix typecheck fix lint
b610438
to
b3a9002
Compare
@ArnoChenFx Closing as not planned. Thank you for contribution. |
Important
Fixes issue in
zep_graphiti.py
whereembedding_model_name
was not being set inget_graphiti()
.embedding_model_name
was not being set inget_graphiti()
inzep_graphiti.py
.client.embedder.config.embedding_model
ifsettings.embedding_model_name
is provided.This description was created by for 28348bc. It will automatically update as commits are pushed.