Allow excluding traffic by matching headers - #5
Merged
Conversation
| private boolean isRequestExcludedByHeader(RequestMetaData request) { | ||
| return excludedHeaders.stream().anyMatch(excludedHeader -> { | ||
| var headerValue = request.getHeaders().get(excludedHeader.headerName()); | ||
| return headerValue != null && excludedHeader.headerValuePattern().matcher(headerValue).matches(); |
There was a problem hiding this comment.
Just out of curiosity, is it possible to have headerValue == null IYO?
Contributor
Author
There was a problem hiding this comment.
Yes it is possible because we go through the list of headers one wants to exclude like x-is-bot. Then request.getHeaders().get("x-is-bot"); can return null if there is no such header sent in the request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exclude requests from validation by specifying headers that match a specific pattern.
This allows to exclude requests from bots that are identifiable through headers.
This can be configured through
application.propertieslike the following: