Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call correct function #51

Merged
merged 1 commit into from
Aug 22, 2023
Merged

Call correct function #51

merged 1 commit into from
Aug 22, 2023

Conversation

hsiehkl
Copy link
Contributor

@hsiehkl hsiehkl commented Aug 22, 2023

Description

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed

Added to documentation?

  • 👍 README.md
  • 👍 CHANGELOG.md
  • 👍 Additional documentation in /docs
  • 👍 Relevant code documentation
  • 🙅 no, because they aren’t needed

@hsiehkl hsiehkl requested a review from a team as a code owner August 22, 2023 11:26
theodoremeynard
theodoremeynard approved these changes Aug 22, 2023
View reviewed changes
Copy link

@theodoremeynard theodoremeynard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsiehkl hsiehkl merged commit c067404 into main Aug 22, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theodoremeynard theodoremeynard theodoremeynard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsiehkl @theodoremeynard