Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a new
$UMBREL_ROOT/bin
directory that should be added to the users$PATH
.We can do this automatically on Umbrel OS but users installing themselves can also add this to their PATH manually.
Currently there are only two binaries,
lncli
andbitcoin-cli
, which just pass all arguments directly through to the equivalent binary inside the docker container and then return the correctly formatted output.This allows you to use globally available
lncli
andbitcoin-cli
binaries and pipe around their output as if they were installed on the host sytem.Example:
It makes debugging and development a lot simpler and I think it's worth including directly in Umbrel OS to make it easier when we're helping user's to debug things too.