Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce repetitive method calls via local variables #576

Closed
wants to merge 3 commits into from
Closed

Reduce repetitive method calls via local variables #576

wants to merge 3 commits into from

Conversation

ashmaroli
Copy link
Contributor

just some syntactic sugar..

gettalong
gettalong requested changes Jan 29, 2019
View reviewed changes
Copy link
Owner

@gettalong gettalong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you - looks good, just change the one variable name.

lib/kramdown/parser/kramdown/link.rb Outdated Show resolved Hide resolved
@ashmaroli
Copy link
Contributor Author

Reminder: Please use Squash and Merge option to merge this PR via GitHub interface

@gettalong gettalong self-assigned this Jan 30, 2019
@gettalong
Copy link
Owner

Thanks for the changes!

@gettalong gettalong closed this Jan 30, 2019
@ashmaroli ashmaroli deleted the cache-with-local-variables branch January 30, 2019 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gettalong gettalong gettalong approved these changes

Assignees

@gettalong gettalong

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashmaroli @gettalong