add swig generating files #29
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The swig files for generating the code again. I also added a new function on the python side to check for an int array explicitly, the old version had a problem doing type checking on windows x64 after python 3.8 because C int are 32bit for sparse matrix and decided to become 64bit afterwards, making the whole thing error out without reasons.
See https://github.com/getspams/spams-python/compare/buildtools?expand=1#diff-460b6ecbea1ce33a85130c32946fe89e220bc7660355bfb71856fe1ecb6e5b05R13 for more info, copied and adapted from the line just below to do the bare minimum.
Note the updated wrappers are coming later and these files do not do anything by themselves for users.