Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/packaging: Create a section on using github-cli to make a pull request #517

Merged
merged 1 commit into from
Apr 7, 2024

Conversation

EbonJaeger
Copy link
Member

Description

Adds a section to the "Submitting a pull request" article about using github-cli to make it.

This uses a tab group so the reader can switch between versions for creating a PR.

Copy link
Contributor

@ermo ermo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this.

Just needs to have repo -> repository per style guide?

@EbonJaeger
Copy link
Member Author

I think I'd rather do all the repo -> repository migrations in a separate PR. There are more than just these two, and I think it's better to have them in the same change scope instead of tacked on to another one.

Copy link
Member

@GZGavinZhao GZGavinZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me on the gh part! Just a small potential addition. It up to you whether to include it or not.

request

Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net>
@davidjharder davidjharder merged commit 32b9481 into master Apr 7, 2024
1 check passed
@davidjharder davidjharder deleted the making-a-pr-with-gh branch April 7, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants