Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add monitoring.yml page #470

Merged
merged 8 commits into from
Feb 4, 2024
Merged

Add monitoring.yml page #470

merged 8 commits into from
Feb 4, 2024

Conversation

davidjharder
Copy link
Member

@davidjharder davidjharder commented Jan 24, 2024 •
edited
Loading

  • Add monitoring.yml page
  • Add some words to the allow list

Largely stolen from @ReillyBrogan 's post on the Serpent Forum

Resolves #468

Part of getsolus/packages#1421

@davidjharder davidjharder marked this pull request as draft January 24, 2024 02:53
@davidjharder davidjharder mentioned this pull request Jan 24, 2024
Open
5 tasks
@davidjharder davidjharder marked this pull request as ready for review January 31, 2024 14:57
@davidjharder
Copy link
Member Author

davidjharder commented Jan 31, 2024 •
edited
Loading

todo

  • Clarify when CVEs should be ignored
  • Mention the CPE search helper script once it is merged
  • Correct link for helper functions

EbonJaeger
EbonJaeger previously requested changes Jan 31, 2024
View reviewed changes
docs/packaging/monitoring.yml.md Show resolved Hide resolved
docs/packaging/monitoring.yml.md Outdated Show resolved Hide resolved
docs/packaging/monitoring.yml.md Outdated Show resolved Hide resolved
deoxys94
deoxys94 suggested changes Feb 1, 2024
View reviewed changes
docs/packaging/monitoring.yml.md Outdated Show resolved Hide resolved
docs/packaging/monitoring.yml.md Outdated Show resolved Hide resolved
docs/packaging/monitoring.yml.md Outdated Show resolved Hide resolved
docs/packaging/monitoring.yml.md Outdated Show resolved Hide resolved
docs/packaging/monitoring.yml.md Show resolved Hide resolved
@EbonJaeger EbonJaeger dismissed their stale review February 2, 2024 19:11

Concerns addressed

@deoxys94
Copy link
Contributor

deoxys94 commented Feb 4, 2024

Hi @davidjharder,

I think the version with tables works better for this topic (Easier to scan, easier to read). I dropped some comments in the file.

deoxys94
deoxys94 suggested changes Feb 4, 2024
View reviewed changes
docs/packaging/monitoring2.yml.md Outdated Show resolved Hide resolved
docs/packaging/monitoring2.yml.md Outdated Show resolved Hide resolved
docs/packaging/monitoring2.yml.md Outdated Show resolved Hide resolved
docs/packaging/monitoring2.yml.md Outdated Show resolved Hide resolved
docs/packaging/monitoring2.yml.md Outdated Show resolved Hide resolved
docs/packaging/monitoring2.yml.md Outdated Show resolved Hide resolved
docs/packaging/monitoring2.yml.md Outdated Show resolved Hide resolved
docs/packaging/monitoring2.yml.md Outdated Show resolved Hide resolved
docs/packaging/monitoring2.yml.md Outdated Show resolved Hide resolved
@joebonrichie
Copy link
Contributor

joebonrichie commented Feb 4, 2024 •
edited by davidjharder
Loading

Need to mention that jq needs to be installed sudo eopkg it jq

@davidjharder
Copy link
Member Author

Need to mention that jq needs to be installed sudo eopkg it jq

I did add jq in "Prepare for packaging" but, your right, another mention would be good

davidjharder and others added 5 commits February 4, 2024 09:17
@davidjharder @deoxys94
Update docs/packaging/monitoring2.yml.md
5cec528 
Co-authored-by: Aldair <deoxys94@gmail.com>
@davidjharder @deoxys94
Update docs/packaging/monitoring2.yml.md
e43ced8 
Co-authored-by: Aldair <deoxys94@gmail.com>
@davidjharder @deoxys94
Update docs/packaging/monitoring2.yml.md
ec71060 
Co-authored-by: Aldair <deoxys94@gmail.com>
@davidjharder @deoxys94
Update docs/packaging/monitoring2.yml.md
d4a25a8 
Co-authored-by: Aldair <deoxys94@gmail.com>
@davidjharder @deoxys94
Update docs/packaging/monitoring2.yml.md
184de55 
Co-authored-by: Aldair <deoxys94@gmail.com>
@davidjharder davidjharder removed the request for review from ReillyBrogan February 4, 2024 22:17
@davidjharder davidjharder merged commit 6e2460a into master Feb 4, 2024
1 check passed
@davidjharder davidjharder deleted the monitoring branch February 4, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deoxys94 deoxys94 deoxys94 requested changes

@EbonJaeger EbonJaeger EbonJaeger left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a monitoring.yml page
4 participants
@davidjharder @deoxys94 @joebonrichie @EbonJaeger