-
Notifications
You must be signed in to change notification settings - Fork 7
Add support for windows paths #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@eliadh the build is failing on Travis... |
OK, I'll check it out. thanks. |
@vmalloc: well, it appears that the fixture for testing the normalized path does not account for Windows file separators which are backslash instead of the usual slash. since the assert is on the exact string, I believe that the unit test may be updated to support windows as well. BTW, this test is the only test that failed (on the local run at my desktop) test name: |
@vmalloc : Updated. please review. thanks! |
@eliadh Travis job is still failing... |
I will make sure |
@eliadh |
Sure. except that the relevant unit test itself doesn't consider windows paths (backslash instead of slash), however, it will pass on Linux. |
I meant did you try it with the fix on Windows and saw that it works correctly? |
Yes. |
Ok. Can you please rebase on |
Done. |
Thanks! |
Hi.
Added support for using backslash plugin from within Windows, which doesn't have unified root but multiple drives instead.
Thanks!