Ensure session reported end on "slash.app_quit" hook (closes #82) #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayalash
force-pushed
the
ayalas/issue-82
branch
from
621fad8 to
14333e4
Compare
|
@vmalloc Can you please review & release a version with this change (after it will be merged)? |
vmalloc
requested changes
Sep 13, 2018
backslash/contrib/slash_plugin.py
Outdated
| @@ -76,6 +77,7 @@ def __init__(self, url=None, keepalive_interval=None, runtoken=None, | |||
| self._error_containers = {} | |||
| self._runtoken = runtoken | |||
| self._propagate_exceptions = propagate_exceptions | |||
| self._ended = False | |||
There was a problem hiding this comment.
This might cause an attempt at cleanup even before session is assigned. It should be set to True and changed to False only after the session is reported as started
ayalash
force-pushed
the
ayalas/issue-82
branch
from
14333e4 to
73b703b
Compare
|
@vmalloc I changed. Can you please review? |
vmalloc
approved these changes
Sep 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.