Skip to content

Support blacklisting warning categories from being reported to backslash (closes #68) #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2018

Conversation

ayalash
Copy link
Collaborator

@ayalash ayalash commented Mar 7, 2018

No description provided.

@ayalash ayalash requested a review from vmalloc March 7, 2018 18:08
Copy link
Member

@vmalloc vmalloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should include a changelog entry as well

@@ -467,6 +469,8 @@ def _add_exception(self, result, exception, is_interruption=False):

@handle_exceptions
def warning_added(self, warning):
if warning.category in self.current_config.blacklisted_warnings_category:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should use issubclass here...

@ayalash
Copy link
Collaborator Author

ayalash commented Mar 10, 2018

@vmalloc I pushed. Please review

@vmalloc vmalloc merged commit 214d849 into develop Mar 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants