feat(runner): Global concurrency pool for file analyses#158
Merged
Conversation
Replace the two-level concurrency model (skill pool x file pool) with a single global semaphore. Previously, `concurrency` controlled how many skills ran in parallel, but each skill also spawned up to 5 file workers, leading to up to 20 concurrent API calls with default settings. Now all skills launch immediately (so the UI shows them as running), but each file analysis must acquire a semaphore permit first. The configured `concurrency` value is the hard cap on simultaneous file analyses across all skills. Fixes #154 Co-Authored-By: Claude <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 3 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
When fileConcurrency was set to MAX_SAFE_INTEGER, two things broke: 1. The batchDelayMs rate-limit check (index >= fileConcurrency) could never trigger, silently disabling the delay feature. 2. runPool spawned one worker per file, grabbing all items before shouldAbort could intervene, making Ctrl+C ineffective for queued files. Fix: use semaphore.initialPermits for the delay threshold, and check the abort signal after acquiring the semaphore (before processing). Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the two-level concurrency model (skill pool x file pool) with a
single global semaphore. Previously,
runner.concurrency(default: 4)controlled how many skills ran in parallel, but each skill also spawned up
to 5 file workers internally. With default settings this meant up to 20
concurrent API calls (4 skills x 5 files).
Now all skills launch immediately (so the UI shows them all as "running"),
but each file analysis must acquire a semaphore permit before starting.
The configured
concurrencyvalue becomes the hard cap on simultaneousfile analyses across all skills.
Approach: A
Semaphoreclass insrc/utils/async.tsis the soleconcurrency gate.
runSkillTaskgains an optional semaphore param thatwraps each file's
processFilecall with acquire/release. The threecallers (
runSkillTasks,runSkillTasksWithInk,executeAllTriggers)create a semaphore from the concurrency config and launch all skills in
parallel with unlimited
fileConcurrency, letting the semaphore do thethrottling.
Fixes #154