ref(sdk): Extract applyMergeGroups to unify cross-location merge logic#153
Merged
ref(sdk): Extract applyMergeGroups to unify cross-location merge logic#153
Conversation
Both dedup.ts and extract.ts duplicated the same group-processing loop for merging findings by LLM-returned groups. Extract into a single applyMergeGroups function in extract.ts and call it from both sites. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract duplicated merge-group processing into a single
applyMergeGroupsfunction.Both
consolidateBatchFindings(dedup.ts) andmergeCrossLocationFindings(extract.ts) contained the same loop for processing LLM-returned merge groups: deduplicating indices, filtering absorbed findings, substituting prior replacements, and callingmergeGroupLocations. This extracts that logic into one shared function in extract.ts.Also adds a small
locationKeyhelper to replace repeated inline string construction, and removespickAndMergeWinnerwhich was a thin wrapper aroundmergeGroupLocations.Net: -21 lines, no behavior change.
Follow-ujp to #148